Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip memray test #6137

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Unskip memray test #6137

merged 1 commit into from
Sep 22, 2023
+2 −1

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Sep 22, 2023 •
edited
Loading

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label Sep 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6137 (5202f3d) into main (7b6b10b) will increase coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6137      +/-   ##
==========================================
+ Coverage   82.42%   82.44%   +0.01%     
==========================================
  Files         350      350              
  Lines       21449    21450       +1     
  Branches      834      839       +5     
==========================================
+ Hits        17680    17685       +5     
+ Misses       3471     3467       -4     
  Partials      298      298

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eivindjahren eivindjahren merged commit 7d9af3d into equinor:main Sep 22, 2023
41 checks passed
@eivindjahren eivindjahren deleted the unskip_memray_test branch September 22, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oysteoh oysteoh oysteoh approved these changes

Assignees
No one assigned
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eivindjahren @codecov-commenter @oysteoh